fix: Add error handling when parsing JSON/YAML spec#356
Open
inFocus7 wants to merge 6 commits intopb33f:mainfrom
Open
fix: Add error handling when parsing JSON/YAML spec#356inFocus7 wants to merge 6 commits intopb33f:mainfrom
inFocus7 wants to merge 6 commits intopb33f:mainfrom
Conversation
Contributor
Author
|
interesting: i'm guessing this is due to an error occurring when parsing the json as it is not valid (at least according to the library). So the paths forward I see are either:
|
Member
|
Hi, Are you planning on completing this? or should I consider it abandoned? |
Member
|
Wrong ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #355
Context
When testing a YAML setup similar to the one added in the test, I noticed no errors were reported and any invalid spec was ignored. While it's not a breaking behavior, it could lead to missing configuration without noticing.
Fix
To fix this we simply should not ignore any errors when parsing.
Open Questions (from me)
bypassmake sense to use as the gate for ignoring (or not) the errors?Concerns (from me)
return specInfo, nil, where we'd return any error.